RDKEMW-7489: Adding Href support by trupthi1403 · Pull Request #54 · rdkcentral/rdkNativeScript

trupthi1403 · 2025-09-06T09:21:50Z

Reason for change: Added Support for Random Num Generator,
                    Local Storage class,
                    Updated node-fetch file for header support
Risks: Low
Priority: P1

rdkcmf-jenkins · 2025-09-06T09:22:58Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/rdkNativeScript/54/rdkcentral/rdkNativeScript
Commit: 424674e

Report detail: gist'

madanagopalt · 2025-09-06T09:49:28Z

    : rtHttpRequest(url)
-  { }
+  {
+  printf("HTTP OBJECT CREATED \n");


please remove this print

madanagopalt · 2025-09-06T09:49:43Z

    : rtHttpRequest(options)
-  { }
+  {
+  printf("HTTP OBJECT CREATED 1 \n");


remove this print

madanagopalt · 2025-09-06T09:49:50Z


  void onDownloadProgressImpl(double progress) final
  {
+printf("DOWNLOAD COMPLETED ............. \n");


remove this print

madanagopalt · 2025-09-06T09:49:56Z


  void onDownloadCompleteImpl(rtFileDownloadRequest* downloadRequest) final
  {
+printf("DOWNLOAD COMPLETED ............. \n");


remove this print

rdkcmf-jenkins · 2025-09-06T09:55:22Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rdkNativeScript/54/rdkcentral/rdkNativeScript
Commit: 424674e

Report detail: gist'

madanagopalt

kindly look at comments

madanagopalt · 2025-09-06T09:50:14Z

      }

      rtObjectRef protectedRef = resp;
+printf("DOWNLOAD COMPLETED ............. \n");


remove this print

madanagopalt · 2025-09-06T09:50:28Z

 {
  UNUSED_PARAM(context);

+printf("CREATING OBJECT HERE1 ........\n");


remove this print

madanagopalt · 2025-09-06T09:50:35Z


  rtHttpRequest* req;
  if (args[0].getType() == RT_stringType) {
+printf("CREATING OBJECT HERE ........\n");


remove this print

madanagopalt · 2025-09-06T09:50:44Z

      return RT_ERROR_INVALID_ARG;
    }
    rtLogInfo("new rtHttpRequest");
+printf("CREATING OBJECT HERE 2........\n");


remove this print

madanagopalt · 2025-09-06T09:52:40Z

-    this.url.query += utf8PercentEncodeString(this.buffer, queryPercentEncodePredicate);
-
+
+	// HACK


Mention as TODO: Check for encryption

madanagopalt · 2025-09-06T09:54:26Z

-		obj[hostHeaderKey] = obj[hostHeaderKey][0];
+	// Convert all header values from arrays to strings for Node.js compatibility
+	for (const key in obj) {
+		if (Array.isArray(obj[key])) {


what if non array?

comments addressed

madanagopalt · 2025-09-06T11:37:16Z


  void onDownloadCompleteImpl(rtFileDownloadRequest* downloadRequest) final
  {
+    fflush(stdout);


Remove this fflush

madanagopalt · 2025-09-06T11:37:25Z

  void onDownloadProgressImpl(double progress) final
  {
+
+    fflush(stdout);


Remove this ffush

madanagopalt · 2025-09-06T11:37:31Z

    : rtHttpRequest(url)
-  { }
+  {
+    fflush(stdout);


Remove this fflush

madanagopalt · 2025-09-06T11:37:46Z

+{
+    if (mExternalApplicationHandler)
+    {
+        printf("Got exteranl application set [%s] in id [%d] \n", url.c_str(), mIds);


Remove this print

madanagopalt · 2025-09-06T11:37:58Z

      }

      rtObjectRef protectedRef = resp;
+      fflush(stdout);


Remove this fflush

madanagopalt

Remove all fflush

Reason for change: Added Support for Random Num Generator, Local Storage class, Updated node-fetch file for header support Risks: Low Priority: P1

madanagopalt reviewed Sep 6, 2025

View reviewed changes

madanagopalt requested changes Sep 6, 2025

View reviewed changes

trupthi1403 force-pushed the topic/RDKEMW-7489 branch from 424674e to 7c21f0b Compare September 6, 2025 10:29

madanagopalt reviewed Sep 6, 2025

View reviewed changes

madanagopalt requested changes Sep 6, 2025

View reviewed changes

gurpreet319 force-pushed the topic/RDKEMW-7489 branch from 7c21f0b to 4a135db Compare September 6, 2025 11:58

RDKEMW-7489: Adding Href support

f09297b

Reason for change: Added Support for Random Num Generator, Local Storage class, Updated node-fetch file for header support Risks: Low Priority: P1

gurpreet319 force-pushed the topic/RDKEMW-7489 branch from 4a135db to f09297b Compare September 6, 2025 11:59

madanagopalt approved these changes Sep 6, 2025

View reviewed changes

madanagopalt merged commit 829286c into develop Sep 6, 2025
5 of 6 checks passed

		this.url.query += utf8PercentEncodeString(this.buffer, queryPercentEncodePredicate);


		// HACK

Conversation

trupthi1403 commented Sep 6, 2025

Uh oh!

rdkcmf-jenkins commented Sep 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins commented Sep 6, 2025

Uh oh!

madanagopalt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madanagopalt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants